morningman commented on code in PR #25768:
URL: https://github.com/apache/doris/pull/25768#discussion_r1368474485
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -1726,7 +1726,7 @@ private void getNewImage(HostInfo helperNode) throws
IOException {
String url = "http://"; + hostPort + "/image?version=" +
version;
String filename = Storage.IMAGE + "." + version;
File dir = new File(this.imageDir);
- MetaHelper.getRemoteFile(url, HTTP_TIMEOUT_SECOND * 1000,
MetaHelper.getFile(filename, dir));
+ MetaHelper.getRemoteFile(url, Config.sync_new_image_timeout,
MetaHelper.getFile(filename, dir));
Review Comment:
```suggestion
MetaHelper.getRemoteFile(url,
Config.sync_new_image_timeout_s * 1000, MetaHelper.getFile(filename, dir));
```
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2259,4 +2259,13 @@ public class Config extends ConfigBase {
})
public static boolean ignore_unknown_metadata_module = false;
+ @ConfField(mutable = true, masterOnly = true, description = {
+
"FE扩容时，从主节点同步元数据的timeout时间，根据${meta_dir}/image文件夹下面的image文件大小和节点间的网络环境调整，" +
+ "单位为毫秒，默认值30000",
+ "The timeout for new FE Follower/Observer synchronizing metadata from
the FE Master, " +
+ "adjust by the size of image file in the ${meta_dir}/image and the
network environment between nodes. " +
+ "The default values is 3000 ms."
+ })
+ public static int sync_new_image_timeout = 30000;
Review Comment:
```suggestion
public static int sync_new_image_timeout_s = 300;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
