BiteTheDDDDt commented on code in PR #19647:
URL: https://github.com/apache/doris/pull/19647#discussion_r1368561911
##########
be/src/common/config.cpp:
##########
@@ -1536,13 +1538,14 @@ Status set_fuzzy_config(const std::string& field, const
std::string& value) {
void set_fuzzy_configs() {
// random value true or false
- static_cast<void>(
- set_fuzzy_config("disable_storage_page_cache", ((rand() % 2) == 0)
? "true" : "false"));
- static_cast<void>(
- set_fuzzy_config("enable_system_metrics", ((rand() % 2) == 0) ?
"true" : "false"));
+ Random generator {(uint32_t)std::time(nullptr)};
+ static_cast<void>(set_fuzzy_config("disable_storage_page_cache",
Review Comment:
remove static_cast<void>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
