924060929 commented on a change in pull request #5160:
URL: https://github.com/apache/incubator-doris/pull/5160#discussion_r549245476
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/MasterOpExecutor.java
##########
@@ -42,7 +42,9 @@
// the total time of thrift connectTime add readTime and writeTime
private int thriftTimeoutMs;
- public MasterOpExecutor(OriginStatement originStmt, ConnectContext ctx,
RedirectStatus status) {
+ private boolean shouldNotRetry;
+
+ public MasterOpExecutor(OriginStatement originStmt, ConnectContext ctx,
RedirectStatus status, boolean isQuery) {
Review comment:
I was discussed this name with my colleague, the constructor of
MasterOpExecutor expose 'shouldRetry' could lead to misuse, because could not
remember the retry related to statement type when invoke `new
MasterOpExecutor()`.
Although `isQuery` doesn't look good, but it always write collect.
And `shouldNotRetry` means exactly that: we should not retry forward to
master. `shouldRetry` mismatch the case that `QueryStatement` timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
