morningman commented on code in PR #25847:
URL: https://github.com/apache/doris/pull/25847#discussion_r1370119194
##########
fe/fe-core/src/main/java/org/apache/doris/backup/Repository.java:
##########
@@ -102,6 +102,7 @@ public class Repository implements Writable {
private static final Logger LOG = LogManager.getLogger(Repository.class);
private static final String PATH_DELIMITER = "/";
private static final String CHECKSUM_SEPARATOR = ".";
+ private static final String PROPERTY_DELETE_STALED_SNAPSHOTS =
"s3.delete_staled_snapshots";
Review Comment:
I think that it is not only for s3 repo, but should for all kinds of repo
(hdfs/broker)
And how about name it `delete_if_exists`?
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/S3URI.java:
##########
@@ -111,16 +111,12 @@ private S3URI(String location, boolean
forceVirtualHosted) throws UserException
// endpoint: http://cos.ap-beijing.myqcloud.com
// bucket/path: my_bucket/file.txt
// `virtualBucket` will be "my_bucket"
- // `bucket` will be `file.txt`
+ // `bucket` will be `/`
+ // `key` will be `file.txt`
// So that when assembling the real endpoint will be:
http://my_bucket.cos.ap-beijing.myqcloud.com/file.txt
this.virtualBucket = authoritySplit[0];
- String[] paths = path.split("/", 2);
- this.bucket = paths[0];
- if (paths.length > 1) {
- key = paths[1];
- } else {
- key = "";
- }
+ this.bucket = "/";
Review Comment:
is it a bug?
Why just setting bucket as `/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
