zhangstar333 commented on code in PR #25859:
URL: https://github.com/apache/doris/pull/25859#discussion_r1371066431
##########
be/src/vec/functions/least_greast.cpp:
##########
@@ -174,6 +174,12 @@ struct FunctionFieldImpl {
auto& res_data = static_cast<ColumnInt32*>(result_column)->get_data();
const auto& column_size = arguments.size();
+ for (int i = 1; i < column_size; ++i) {
+ block.replace_by_position(
+ arguments[i],
+
ColumnConst::create(block.get_by_position(arguments[i]).column, 1));
+ }
Review Comment:
no need convert it, could set use_default_implementation_for_constants() =
true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
