github-actions[bot] commented on code in PR #25871:
URL: https://github.com/apache/doris/pull/25871#discussion_r1371081792
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.h:
##########
@@ -166,14 +166,29 @@ class PipelineXFragmentContext : public
PipelineFragmentContext {
// build probe operator and build operator in separate pipelines. To do
this, we should build
// ProbeSide first, and use `_pipelines_to_build` to store which pipeline
the build operator
// is in, so we can build BuildSide once we complete probe side.
- std::map<int, PipelinePtr> _build_side_pipelines;
+ struct Pipelines_Stack {
+ std::map<int, std::vector<PipelinePtr>> _build_side_pipelines;
+ void push(int parent_node_id, PipelinePtr pipeline) {
+ if (!_build_side_pipelines.contains(parent_node_id)) {
+ _build_side_pipelines.insert({parent_node_id, {pipeline}});
+ } else {
+ _build_side_pipelines[parent_node_id].push_back(pipeline);
+ }
+ }
+ void pop(PipelinePtr& cur_pipe, int parent_node_id, int child_idx) {
Review Comment:
warning: method 'pop' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void pop(PipelinePtr& cur_pipe, int parent_node_id, int
child_idx) {
```
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.h:
##########
@@ -166,14 +166,29 @@ class PipelineXFragmentContext : public
PipelineFragmentContext {
// build probe operator and build operator in separate pipelines. To do
this, we should build
// ProbeSide first, and use `_pipelines_to_build` to store which pipeline
the build operator
// is in, so we can build BuildSide once we complete probe side.
- std::map<int, PipelinePtr> _build_side_pipelines;
+ struct Pipelines_Stack {
+ std::map<int, std::vector<PipelinePtr>> _build_side_pipelines;
+ void push(int parent_node_id, PipelinePtr pipeline) {
Review Comment:
warning: method 'push' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void push(int parent_node_id, PipelinePtr pipeline) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
