github-actions[bot] commented on code in PR #25705:
URL: https://github.com/apache/doris/pull/25705#discussion_r1366910344
##########
be/src/olap/tablet.cpp:
##########
@@ -3567,18 +3567,24 @@ Status Tablet::check_rowid_conversion(
return Status::OK();
}
-RowsetIdUnorderedSet Tablet::all_rs_id(int64_t max_version) const {
- RowsetIdUnorderedSet rowset_ids;
- for (const auto& rs_it : _rs_version_map) {
- if (rs_it.first.second == 1) {
+Status Tablet::all_rs_id(int64_t max_version, RowsetIdUnorderedSet*
rowset_ids) const {
+ // Ensure that the obtained versions of rowsets are continuous
Review Comment:
warning: method 'all_rs_id' can be made static
[readability-convert-member-functions-to-static]
```suggestion
}
orderedSet* rowset_ids) consstatic t {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
