morningman commented on a change in pull request #5170:
URL: https://github.com/apache/incubator-doris/pull/5170#discussion_r550973402
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1311,4 +1311,9 @@
*/
@ConfField(mutable = true, masterOnly = true)
public static boolean enable_fe_heartbeat_by_thrift = false;
+
+ /**
+ * default value for insert_visible_timeout_ms
+ */
+ public static long default_insert_visible_timeout_ms = 10000;
Review comment:
If we use session variable, there is no need to add this config.
I think session variable is enough.
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -112,6 +112,12 @@
// when true, the partition column must be set to NOT NULL.
public static final String ALLOW_PARTITION_COLUMN_NULLABLE =
"allow_partition_column_nullable";
+ // max ms to wait transaction publish finish when exec insert stmt.
+ public static final String INSERT_VISIBLE_TIMEOUT_MS =
"insert_visible_timeout_ms";
+
+ @VariableMgr.VarAttr(name = INSERT_VISIBLE_TIMEOUT_MS)
+ private long insertVisibleTimeoutMs = -1;
Review comment:
Set default to 10000, and the config is not used any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
