yiguolei commented on code in PR #25901:
URL: https://github.com/apache/doris/pull/25901#discussion_r1371551787
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -410,26 +411,48 @@ Status VScanNode::_normalize_conjuncts() {
}
}
+ std::function<bool(const VExprSPtr&)> _conjunct_is_acting_on_a_slot =
+ [&_conjunct_is_acting_on_a_slot](const VExprSPtr& expr) -> bool {
+ const auto& children = expr->children();
+ const size_t children_size = children.size();
+
+ for (size_t i = 0; i < children_size; ++i) {
+ // If any child expr does not act on a column slot
+ // return false immediately.
+ if (!_conjunct_is_acting_on_a_slot(children[i])) {
Review Comment:
这样做应该是不对的，应该是，只要有一个acting on slot，那么就应该是true；其他的是false
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -410,26 +411,48 @@ Status VScanNode::_normalize_conjuncts() {
}
}
+ std::function<bool(const VExprSPtr&)> _conjunct_is_acting_on_a_slot =
+ [&_conjunct_is_acting_on_a_slot](const VExprSPtr& expr) -> bool {
+ const auto& children = expr->children();
+ const size_t children_size = children.size();
+
+ for (size_t i = 0; i < children_size; ++i) {
+ // If any child expr does not act on a column slot
+ // return false immediately.
+ if (!_conjunct_is_acting_on_a_slot(children[i])) {
Review Comment:
这样做应该是不对的，应该是，只要有一个acting on slot，那么就应该是true；其他的是false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
