JNSimba commented on code in PR #206:
URL:
https://github.com/apache/doris-flink-connector/pull/206#discussion_r1372780950
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/SchemaChangeHelper.java:
##########
@@ -57,6 +58,24 @@ public static void compareSchema(Map<String, FieldSchema>
updateFiledSchemaMap,
}
}
+ public static List<String> generateRenameDDLSql(String table, String
oldColumnName, String newColumnName,
+ Map<String, FieldSchema> originFieldSchemaMap) {
+ ddlSchemas.clear();
+ List<String> ddlList = Lists.newArrayList();
+ FieldSchema fieldSchema = null;
+ for (Entry<String, FieldSchema> originFieldSchema :
originFieldSchemaMap.entrySet()) {
+ if (originFieldSchema.getKey().equals(oldColumnName)) {
+ fieldSchema = originFieldSchema.getValue();
+ String renameSQL = String.format(RENAME_DDL, table,
oldColumnName, newColumnName);
+ ddlList.add(renameSQL);
+ ddlSchemas.add(new DDLSchema(oldColumnName, false));
+ }
+ }
+ originFieldSchemaMap.remove(oldColumnName);
+ originFieldSchemaMap.put(newColumnName, fieldSchema);
+ return ddlList;
+ }
+
Review Comment:
please add ut，thanks
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/SchemaChangeHelper.java:
##########
@@ -57,6 +58,24 @@ public static void compareSchema(Map<String, FieldSchema>
updateFiledSchemaMap,
}
}
+ public static List<String> generateRenameDDLSql(String table, String
oldColumnName, String newColumnName,
+ Map<String, FieldSchema> originFieldSchemaMap) {
+ ddlSchemas.clear();
+ List<String> ddlList = Lists.newArrayList();
+ FieldSchema fieldSchema = null;
+ for (Entry<String, FieldSchema> originFieldSchema :
originFieldSchemaMap.entrySet()) {
+ if (originFieldSchema.getKey().equals(oldColumnName)) {
+ fieldSchema = originFieldSchema.getValue();
+ String renameSQL = String.format(RENAME_DDL, table,
oldColumnName, newColumnName);
+ ddlList.add(renameSQL);
+ ddlSchemas.add(new DDLSchema(oldColumnName, false));
+ }
+ }
+ originFieldSchemaMap.remove(oldColumnName);
+ originFieldSchemaMap.put(newColumnName, fieldSchema);
+ return ddlList;
+ }
+
Review Comment:
please add ut，thanks
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/JsonDebeziumSchemaSerializer.java:
##########
@@ -249,12 +251,24 @@ public List<String> extractDDLList(JsonNode record)
throws JsonProcessingExcepti
sourceConnector =
SourceConnector.valueOf(record.get("source").get("connector").asText().toUpperCase());
fillOriginSchema(columns);
}
+
+ // rename ddl
+ Matcher renameMatcher = renameDDLPattern.matcher(ddl);
+ if (renameMatcher.find()) {
+ String oldColumnName = renameMatcher.group(2);
+ String newColumnName = renameMatcher.group(3);
+ return SchemaChangeHelper.generateRenameDDLSql(
+ dorisOptions.getTableIdentifier(), oldColumnName,
newColumnName, originFieldSchemaMap);
+ }
+
Review Comment:
please add ut，thanks
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/JsonDebeziumSchemaSerializer.java:
##########
@@ -249,12 +251,24 @@ public List<String> extractDDLList(JsonNode record)
throws JsonProcessingExcepti
sourceConnector =
SourceConnector.valueOf(record.get("source").get("connector").asText().toUpperCase());
fillOriginSchema(columns);
}
+
+ // rename ddl
+ Matcher renameMatcher = renameDDLPattern.matcher(ddl);
+ if (renameMatcher.find()) {
+ String oldColumnName = renameMatcher.group(2);
+ String newColumnName = renameMatcher.group(3);
+ return SchemaChangeHelper.generateRenameDDLSql(
+ dorisOptions.getTableIdentifier(), oldColumnName,
newColumnName, originFieldSchemaMap);
+ }
+
Review Comment:
please add ut，thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
