github-actions[bot] commented on code in PR #25964:
URL: https://github.com/apache/doris/pull/25964#discussion_r1372964984
##########
be/src/pipeline/pipeline_x/local_exchange/local_exchange_sink_operator.cpp:
##########
@@ -27,33 +27,38 @@ Status LocalExchangeSinkLocalState::init(RuntimeState*
state, LocalSinkStateInfo
_distribute_timer = ADD_TIMER(profile(), "DistributeDataTime");
auto& p = _parent->cast<LocalExchangeSinkOperatorX>();
RETURN_IF_ERROR(p._partitioner->clone(state, _partitioner));
- _mutable_block.resize(p._num_partitions);
_shared_state->running_sink_operators++;
return Status::OK();
}
-Status LocalExchangeSinkLocalState::channel_add_rows(RuntimeState* state,
- const uint32_t*
__restrict channel_ids,
- vectorized::Block* block,
- SourceState source_state)
{
+Status LocalExchangeSinkLocalState::split_rows(RuntimeState* state,
Review Comment:
warning: method 'split_rows' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/local_exchange/local_exchange_sink_operator.h:36:
```diff
- Status split_rows(RuntimeState* state, const uint32_t* __restrict
channel_ids,
+ static Status split_rows(RuntimeState* state, const uint32_t*
__restrict channel_ids,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
