englefly commented on code in PR #25874:
URL: https://github.com/apache/doris/pull/25874#discussion_r1373993202
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/ExpressionDeepCopier.java:
##########
@@ -75,6 +79,62 @@ public Expression visitSlotReference(SlotReference
slotReference, DeepCopierCont
}
}
+ @Override
+ public Expression visitMarkJoinReference(MarkJoinSlotReference
slotReference, DeepCopierContext context) {
+ Map<ExprId, ExprId> exprIdReplaceMap = context.exprIdReplaceMap;
+ if (exprIdReplaceMap.containsKey(slotReference.getExprId())) {
+ ExprId newExprId = exprIdReplaceMap.get(slotReference.getExprId());
+ return slotReference.withExprId(newExprId);
+ } else {
+ MarkJoinSlotReference newOne =
slotReference.withExprId(StatementScopeIdGenerator.newExprId());
+ exprIdReplaceMap.put(slotReference.getExprId(),
newOne.getExprId());
+ return newOne;
+ }
+ }
+
+ @Override
+ public Expression visitArrayItemSlot(ArrayItemReference.ArrayItemSlot
slotReference, DeepCopierContext context) {
Review Comment:
use withExprId, and we do not need visitXXXSlot method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
