This is an automated email from the ASF dual-hosted git repository.
eldenmoon pushed a commit to branch branch-2.0-var
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0-var by this push:
new b35e1366699 fix chinese sub column name
b35e1366699 is described below
commit b35e1366699542f11d5d836e6f4bacbd7e47d1bd
Author: eldenmoon <[email protected]>
AuthorDate: Sun Oct 22 21:23:00 2023 +0800
fix chinese sub column name
---
be/src/vec/columns/column_object.cpp | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/be/src/vec/columns/column_object.cpp
b/be/src/vec/columns/column_object.cpp
index 13dfe477303..38a93b37086 100644
--- a/be/src/vec/columns/column_object.cpp
+++ b/be/src/vec/columns/column_object.cpp
@@ -904,10 +904,10 @@ bool ColumnObject::is_finalized() const {
[](const auto& entry) { return
entry->data.is_finalized(); });
}
-static bool check_if_valid_column_name(const PathInData& path) {
- static const std::regex
COLUMN_NAME_REGEX("^[_a-zA-Z@0-9][.a-zA-Z0-9_+-/><?@#$%^&*]{0,255}$");
- return std::regex_match(path.get_path(), COLUMN_NAME_REGEX);
-}
+// static bool check_if_valid_column_name(const PathInData& path) {
+// static const std::regex
COLUMN_NAME_REGEX("^[_a-zA-Z@0-9][.a-zA-Z0-9_+-/><?@#$%^&*]{0,255}$");
+// return std::regex_match(path.get_path(), COLUMN_NAME_REGEX);
+// }
void ColumnObject::Subcolumn::wrapp_array_nullable() {
// Wrap array with nullable, treat empty array as null to elimate conflict
at present
@@ -1186,8 +1186,7 @@ void ColumnObject::finalize(bool ignore_sparse) {
}
// Check and spilit sparse subcolumns
- if (!ignore_sparse && (entry->data.check_if_sparse_column(num_rows) ||
- !check_if_valid_column_name(entry->path))) {
+ if (!ignore_sparse && (entry->data.check_if_sparse_column(num_rows))) {
// TODO seperate ambiguous path
sparse_columns.add(entry->path, entry->data);
continue;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
