stdpain commented on issue #5213: URL: https://github.com/apache/incubator-doris/issues/5213#issuecomment-757126787
@acelyc111 > [@stdpain](https://github.com/stdpain) [#5124](https://github.com/apache/incubator-doris/pull/5124) is not well fix it, we should join the compaction thread in StorageEngine's stop() function :) pass a shared_ptr to the compaction thread , so we don't have to join compaction thread ```c++ [this]() { this->shared_from_this()->_compaction_tasks_producer_callback(); } ``` 'this' pointer won't be freed unless all background thread exited ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
