HappenLee commented on a change in pull request #5214:
URL: https://github.com/apache/incubator-doris/pull/5214#discussion_r554585086
##########
File path: be/src/util/doris_metrics.h
##########
@@ -207,11 +209,17 @@ class DorisMetrics {
static const std::string _s_registry_name;
static const std::string _s_hook_name;
+ // used for hold a reference count from CoreLocalValueController
+ // we should make sure that DorisMetrics is released after
CoreLocalValueController
+ std::shared_ptr<CoreLocalValueController<int64_t>> _int64_counter_ref =
CoreLocalValueController<int64_t>::reference();
+ std::shared_ptr<CoreLocalValueController<uint64_t>> _uint64_counter_ref =
CoreLocalValueController<uint64_t>::reference();
+
MetricRegistry _metric_registry;
std::unique_ptr<SystemMetrics> _system_metrics;
std::shared_ptr<MetricEntity> _server_metric_entity;
+
Review comment:
no need add necessary space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
