github-actions[bot] commented on code in PR #26158:
URL: https://github.com/apache/doris/pull/26158#discussion_r1377168255
##########
be/src/vec/common/hash_table/hash_map.h:
##########
@@ -266,7 +266,7 @@ class JoinHashMapTable : public HashMapTable<Key, Cell,
Hash, Grower, Allocator>
JoinOpType == doris::TJoinOp::RIGHT_SEMI_JOIN) {
return _find_batch_right_semi_anti(keys, bucket_nums, probe_idx,
probe_rows);
}
- return std::pair {0, 0};
+ return std::tuple {0, 0u, 0};
Review Comment:
warning: integer literal has suffix 'u', which is not uppercase
[readability-uppercase-literal-suffix]
```suggestion
return std::tuple {0, 0U, 0};
```
##########
be/src/vec/common/hash_table/hash_map.h:
##########
@@ -331,17 +331,17 @@
matched_cnt += matched;
probe_idxs[matched_cnt - matched] = probe_idx++;
}
- return std::pair {probe_idx, matched_cnt};
+ return std::tuple {probe_idx, 0u, matched_cnt};
Review Comment:
warning: integer literal has suffix 'u', which is not uppercase
[readability-uppercase-literal-suffix]
```suggestion
return std::tuple {probe_idx, 0U, matched_cnt};
```
##########
be/src/vec/common/hash_table/hash_map.h:
##########
@@ -306,7 +306,7 @@
}
probe_idx++;
}
- return std::pair {probe_idx, 0};
+ return std::tuple {probe_idx, 0u, 0};
Review Comment:
warning: integer literal has suffix 'u', which is not uppercase
[readability-uppercase-literal-suffix]
```suggestion
return std::tuple {probe_idx, 0U, 0};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
