github-actions[bot] commented on code in PR #26168:
URL: https://github.com/apache/doris/pull/26168#discussion_r1377278726
##########
be/src/io/fs/multi_table_pipe.cpp:
##########
@@ -300,7 +300,8 @@ Status MultiTablePipe::exec_plans(ExecEnv* exec_env,
std::vector<ExecParam> para
#endif
-Status MultiTablePipe::putPipe(const TUniqueId& pipe_id,
std::shared_ptr<io::StreamLoadPipe> pipe) {
+Status MultiTablePipe::put_pipe(const TUniqueId& pipe_id,
Review Comment:
warning: method 'put_pipe' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status MultiTablePipe::put_pipe(const TUniqueId& pipe_id,
```
##########
be/src/io/fs/multi_table_pipe.cpp:
##########
@@ -310,16 +311,16 @@
return Status::OK();
}
-std::shared_ptr<io::StreamLoadPipe> MultiTablePipe::getPipe(const TUniqueId&
pipe_id) {
+std::shared_ptr<io::StreamLoadPipe> MultiTablePipe::get_pipe(const TUniqueId&
pipe_id) {
std::lock_guard<std::mutex> l(_pipe_map_lock);
auto it = _pipe_map.find(pipe_id);
if (it == std::end(_pipe_map)) {
- return std::shared_ptr<io::StreamLoadPipe>(nullptr);
+ return {};
}
return it->second;
}
-void MultiTablePipe::removePipe(const TUniqueId& pipe_id) {
+void MultiTablePipe::remove_pipe(const TUniqueId& pipe_id) {
Review Comment:
warning: method 'remove_pipe' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void MultiTablePipe::remove_pipe(const TUniqueId& pipe_id) {
```
##########
be/src/io/fs/multi_table_pipe.cpp:
##########
@@ -310,16 +311,16 @@
return Status::OK();
}
-std::shared_ptr<io::StreamLoadPipe> MultiTablePipe::getPipe(const TUniqueId&
pipe_id) {
+std::shared_ptr<io::StreamLoadPipe> MultiTablePipe::get_pipe(const TUniqueId&
pipe_id) {
Review Comment:
warning: method 'get_pipe' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static std::shared_ptr<io::StreamLoadPipe> MultiTablePipe::get_pipe(const
TUniqueId& pipe_id) {
```
##########
be/src/vec/exec/format/json/new_json_reader.cpp:
##########
@@ -159,8 +157,7 @@ void NewJsonReader::_init_file_description() {
}
Status NewJsonReader::init_reader(
- const std::unordered_map<std::string, vectorized::VExprContextSPtr>&
- col_default_value_ctx) {
+ const std::unordered_map<std::string, VExprContextSPtr>&
col_default_value_ctx) {
Review Comment:
warning: all parameters should be named in a function
[readability-named-parameter]
```suggestion
const std::unordered_map<std::string, VExprContextSPtr> /*unused*/&
col_default_value_ctx) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
