platoneko commented on code in PR #26167:
URL: https://github.com/apache/doris/pull/26167#discussion_r1377568390
##########
be/src/pipeline/exec/olap_scan_operator.cpp:
##########
@@ -247,21 +247,29 @@ Status
OlapScanLocalState::_init_scanners(std::list<vectorized::VScannerSPtr>* s
}
int scanners_per_tablet = std::max(1, 64 / (int)_scan_ranges.size());
- auto build_new_scanner = [&](const TPaloScanRange& scan_range,
+ auto build_new_scanner = [&](BaseTabletSPtr tablet, int64_t version,
const std::vector<OlapScanRange*>&
key_ranges) {
- std::shared_ptr<vectorized::NewOlapScanner> scanner =
- vectorized::NewOlapScanner::create_shared(
- state(), this, p._limit_per_scanner,
p._olap_scan_node.is_preaggregation,
- scan_range, key_ranges, _scanner_profile.get());
-
+ auto scanner = vectorized::NewOlapScanner::create_shared(
+ this, vectorized::NewOlapScanner::Params {
+ state(),
Review Comment:
不行啊，这个是国垒老师的 create shared，推导不出来类型
##########
be/src/pipeline/exec/olap_scan_operator.cpp:
##########
@@ -247,21 +247,29 @@ Status
OlapScanLocalState::_init_scanners(std::list<vectorized::VScannerSPtr>* s
}
int scanners_per_tablet = std::max(1, 64 / (int)_scan_ranges.size());
- auto build_new_scanner = [&](const TPaloScanRange& scan_range,
+ auto build_new_scanner = [&](BaseTabletSPtr tablet, int64_t version,
const std::vector<OlapScanRange*>&
key_ranges) {
- std::shared_ptr<vectorized::NewOlapScanner> scanner =
- vectorized::NewOlapScanner::create_shared(
- state(), this, p._limit_per_scanner,
p._olap_scan_node.is_preaggregation,
- scan_range, key_ranges, _scanner_profile.get());
-
+ auto scanner = vectorized::NewOlapScanner::create_shared(
+ this, vectorized::NewOlapScanner::Params {
+ state(),
Review Comment:
不行啊，这个是国垒老师的 create shared，推导不出来类型
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
