github-actions[bot] commented on code in PR #25946:
URL: https://github.com/apache/doris/pull/25946#discussion_r1378583125
##########
be/src/vec/data_types/data_type_time.h:
##########
@@ -69,7 +69,9 @@ class DataTypeTime final : public DataTypeNumberBase<Float64>
{
bool can_be_used_in_boolean_context() const override { return true; }
bool can_be_inside_nullable() const override { return true; }
- DataTypeSerDeSPtr get_serde() const override { return
std::make_shared<DataTypeTimeSerDe>(); };
+ DataTypeSerDeSPtr get_serde(int nesting_level = 1) const override {
Review Comment:
warning: method 'get_serde' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataTypeSerDeSPtr get_serde(int nesting_level = 1) override {
```
##########
be/src/vec/data_types/data_type_date_time.h:
##########
@@ -86,8 +86,8 @@ class DataTypeDateTime final : public
DataTypeNumberBase<Int64> {
std::string to_string(const IColumn& column, size_t row_num) const
override;
- DataTypeSerDeSPtr get_serde() const override {
- return std::make_shared<DataTypeDateTimeSerDe>();
+ DataTypeSerDeSPtr get_serde(int nesting_level = 1) const override {
Review Comment:
warning: method 'get_serde' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataTypeSerDeSPtr get_serde(int nesting_level = 1) override {
```
##########
be/src/vec/data_types/data_type_time_v2.h:
##########
@@ -69,7 +69,9 @@ class DataTypeDateV2 final : public
DataTypeNumberBase<UInt32> {
bool can_be_inside_nullable() const override { return true; }
- DataTypeSerDeSPtr get_serde() const override { return
std::make_shared<DataTypeDateV2SerDe>(); }
+ DataTypeSerDeSPtr get_serde(int nesting_level = 1) const override {
Review Comment:
warning: method 'get_serde' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataTypeSerDeSPtr get_serde(int nesting_level = 1) override {
```
##########
be/src/vec/data_types/serde/data_type_nullable_serde.cpp:
##########
@@ -177,18 +172,18 @@ Status
DataTypeNullableSerDe::deserialize_one_cell_from_json(IColumn& column, Sl
* and "null" literal will be stored in doris.
*
*/
- if (nesting_level >= 2 && slice.size == 4 && slice[0] == 'n' &&
slice[1] == 'u' &&
+ if (_nesting_level >= 2 && slice.size == 4 && slice[0] == 'n' &&
slice[1] == 'u' &&
slice[2] == 'l' && slice[3] == 'l') {
null_column.insert_data(nullptr, 0);
return Status::OK();
- } else if (nesting_level == 1 && slice.size == 2 && slice[0] == '\\'
&& slice[1] == 'N') {
+ } else if (_nesting_level == 1 && slice.size == 2 && slice[0] == '\\'
&& slice[1] == 'N') {
null_column.insert_data(nullptr, 0);
return Status::OK();
}
}
Review Comment:
warning: do not use 'else' after 'return' [readability-else-after-return]
```suggestion
;
{
;
;
}if (_nesting_level == 1 && slice.size == 2 && slice[0] == '\\' && slice[1]
== 'N') {
null_column.insert_data(nullptr, 0);
return Status::OK();
}
```
##########
be/src/vec/data_types/data_type_ipv6.h:
##########
@@ -72,7 +72,9 @@ class DataTypeIPv6 final : public DataTypeNumberBase<IPv6> {
MutableColumnPtr create_column() const override;
- DataTypeSerDeSPtr get_serde() const override { return
std::make_shared<DataTypeIPv6SerDe>(); }
+ DataTypeSerDeSPtr get_serde(int nesting_level = 1) const override {
Review Comment:
warning: method 'get_serde' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataTypeSerDeSPtr get_serde(int nesting_level = 1) override {
```
##########
be/src/vec/data_types/data_type_date.h:
##########
@@ -77,7 +77,9 @@ class DataTypeDate final : public DataTypeNumberBase<Int64> {
MutableColumnPtr create_column() const override;
- DataTypeSerDeSPtr get_serde() const override { return
std::make_shared<DataTypeDate64SerDe>(); }
+ DataTypeSerDeSPtr get_serde(int nesting_level = 1) const override {
Review Comment:
warning: method 'get_serde' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataTypeSerDeSPtr get_serde(int nesting_level = 1) override {
```
##########
be/src/vec/data_types/data_type_ipv4.h:
##########
@@ -64,7 +64,9 @@ class DataTypeIPv4 final : public DataTypeNumberBase<IPv4> {
MutableColumnPtr create_column() const override;
- DataTypeSerDeSPtr get_serde() const override { return
std::make_shared<DataTypeIPv4SerDe>(); }
+ DataTypeSerDeSPtr get_serde(int nesting_level = 1) const override {
Review Comment:
warning: method 'get_serde' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataTypeSerDeSPtr get_serde(int nesting_level = 1) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
