yiguolei commented on code in PR #26191:
URL: https://github.com/apache/doris/pull/26191#discussion_r1378871450
##########
be/src/olap/predicate_creator.h:
##########
@@ -49,7 +49,7 @@ class PredicateCreator {
template <PrimitiveType Type, PredicateType PT, typename ConditionType>
class IntegerPredicateCreator : public PredicateCreator<ConditionType> {
public:
Review Comment:
maybe not right here. because many predicate parse the value from string,
and olap scannode convert the predicate value to a string and predicate
creator parse the value from string.
If you do not change olap scannode code, then I think you could not parse
the value correctly.
I think, maybe we should delete predicate creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
