xzj7019 commented on code in PR #25969:
URL: https://github.com/apache/doris/pull/25969#discussion_r1379483501
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -151,10 +151,8 @@ public class Rewriter extends AbstractBatchJobExecutor {
// we need run the following 2 rules to make
AGG_SCALAR_SUBQUERY_TO_WINDOW_FUNCTION work
bottomUp(new PullUpProjectUnderApply()),
topDown(new PushdownFilterThroughProject()),
- costBased(
-
custom(RuleType.AGG_SCALAR_SUBQUERY_TO_WINDOW_FUNCTION,
- AggScalarSubQueryToWindowFunction::new)
- ),
+ custom(RuleType.AGG_SCALAR_SUBQUERY_TO_WINDOW_FUNCTION,
Review Comment:
it is not always to have positive return for this costbased rule, under our
current incomplete code model, we also need a mechanism to control this for on
or off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
