morningman commented on a change in pull request #5315:
URL: https://github.com/apache/incubator-doris/pull/5315#discussion_r566179490



##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -753,6 +753,8 @@ private void addColumnInternal(OlapTable olapTable, Column 
newColumn, ColumnPosi
                 throw new DdlException("Can not assign aggregation method on 
key column: " +  newColName);
             } else if (null == newColumn.getAggregationType()) {
                 newColumn.setIsKey(true);
+            } else if (newColumn.getAggregationType() == AggregateType.SUM && 
!newColumn.getDefaultValue().equals("0")) {

Review comment:
       `newColumn.getDefaultValue()` may be `null` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to