deardeng commented on code in PR #26412:
URL: https://github.com/apache/doris/pull/26412#discussion_r1384338525
##########
fe/fe-core/src/main/java/org/apache/doris/clone/Rebalancer.java:
##########
@@ -77,6 +86,31 @@ public List<TabletSchedCtx> selectAlternativeTablets() {
protected abstract List<TabletSchedCtx> selectAlternativeTabletsForCluster(
LoadStatisticForTag clusterStat, TStorageMedium medium);
+ protected boolean isNeedBalanced(LoadStatisticForTag clusterStat,
TStorageMedium medium,
+ List<Long> fromBes, List<Long> toBes) {
+ return true;
+ }
+
+ protected boolean unPickOverLongTime(LoadStatisticForTag clusterStat,
TStorageMedium medium) {
+ if (lastPickTimeTable.containsRow(clusterStat)) {
+ Map<TStorageMedium, Long> mediumLastPickTimeMap =
lastPickTimeTable.row(clusterStat);
+ if (mediumLastPickTimeMap.containsKey(medium)) {
+ Long lastPickTimeTable = mediumLastPickTimeMap.get(medium);
Review Comment:
fixed
##########
fe/fe-core/src/main/java/org/apache/doris/clone/TabletScheduler.java:
##########
@@ -1472,6 +1475,7 @@ private void finalizeTabletCtx(TabletSchedCtx tabletCtx,
TabletSchedCtx.State st
if (state == TabletSchedCtx.State.FINISHED) {
tryAddAfterFinished(tabletCtx);
}
+ rebalancer.removeFromLastPickTimeTable(tabletCtx.getTag(),
tabletCtx.getStorageMedium());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
