github-actions[bot] commented on code in PR #26526:
URL: https://github.com/apache/doris/pull/26526#discussion_r1384685843
##########
be/src/vec/sink/delta_writer_v2_pool.cpp:
##########
@@ -29,8 +29,8 @@ DeltaWriterV2Map::DeltaWriterV2Map(UniqueId load_id) :
_load_id(load_id), _use_c
DeltaWriterV2Map::~DeltaWriterV2Map() = default;
-DeltaWriterV2* DeltaWriterV2Map::get_or_create(int64_t tablet_id,
- std::function<DeltaWriterV2*()>
creator) {
+DeltaWriterV2* DeltaWriterV2Map::get_or_create(
+ int64_t tablet_id, std::function<std::unique_ptr<DeltaWriterV2>()>
creator) {
Review Comment:
warning: all parameters should be named in a function
[readability-named-parameter]
```suggestion
int64_t tablet_id, std::function<std::unique_ptr<DeltaWriterV2>(
/*unused*/)> creator) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
