This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 2bb3ef19814 [refactor](scan) delete bloom_filter_predicate (#26499)
2bb3ef19814 is described below
commit 2bb3ef198144954583aea106591959ee09932cba
Author: Jerry Hu <[email protected]>
AuthorDate: Tue Nov 7 19:37:31 2023 +0800
[refactor](scan) delete bloom_filter_predicate (#26499)
---
be/src/exprs/create_predicate_function.h | 12 +-
be/src/olap/bloom_filter_predicate.h | 197 ---------------------
be/src/olap/olap_common.h | 1 +
be/src/olap/predicate_creator.h | 1 -
be/src/olap/reader.cpp | 16 --
be/src/olap/reader.h | 3 -
be/src/olap/rowset/segment_v2/segment_iterator.cpp | 3 +-
be/src/pipeline/exec/olap_scan_operator.cpp | 2 +
be/src/pipeline/exec/olap_scan_operator.h | 1 +
be/src/pipeline/exec/scan_operator.cpp | 20 ---
be/src/pipeline/exec/scan_operator.h | 3 -
be/src/vec/exec/scan/new_olap_scan_node.cpp | 2 +
be/src/vec/exec/scan/new_olap_scan_node.h | 1 +
be/src/vec/exec/scan/new_olap_scanner.cpp | 1 +
be/src/vec/exec/scan/vscan_node.cpp | 17 --
be/src/vec/exec/scan/vscan_node.h | 3 -
16 files changed, 11 insertions(+), 272 deletions(-)
diff --git a/be/src/exprs/create_predicate_function.h
b/be/src/exprs/create_predicate_function.h
index 0e792563acf..f4e0601459e 100644
--- a/be/src/exprs/create_predicate_function.h
+++ b/be/src/exprs/create_predicate_function.h
@@ -17,11 +17,11 @@
#pragma once
+#include "bloom_filter_func.h"
#include "exprs/hybrid_set.h"
#include "exprs/minmax_predicate.h"
#include "function_filter.h"
#include "olap/bitmap_filter_predicate.h"
-#include "olap/bloom_filter_predicate.h"
#include "olap/column_predicate.h"
#include "olap/in_list_predicate.h"
#include "olap/like_column_predicate.h"
@@ -225,16 +225,6 @@ inline auto create_bitmap_filter(PrimitiveType type) {
return create_bitmap_predicate_function<BitmapFilterTraits>(type);
}
-template <PrimitiveType PT>
-ColumnPredicate* create_olap_column_predicate(uint32_t column_id,
- const
std::shared_ptr<BloomFilterFuncBase>& filter,
- int be_exec_version, const
TabletColumn*) {
- std::shared_ptr<BloomFilterFuncBase> filter_olap;
- filter_olap.reset(create_bloom_filter(PT));
- filter_olap->light_copy(filter.get());
- return new BloomFilterColumnPredicate<PT>(column_id, filter,
be_exec_version);
-}
-
template <PrimitiveType PT>
ColumnPredicate* create_olap_column_predicate(uint32_t column_id,
const
std::shared_ptr<BitmapFilterFuncBase>& filter,
diff --git a/be/src/olap/bloom_filter_predicate.h
b/be/src/olap/bloom_filter_predicate.h
deleted file mode 100644
index d2816be9966..00000000000
--- a/be/src/olap/bloom_filter_predicate.h
+++ /dev/null
@@ -1,197 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-#pragma once
-
-#include "exprs/bloom_filter_func.h"
-#include "exprs/runtime_filter.h"
-#include "olap/column_predicate.h"
-#include "runtime/primitive_type.h"
-#include "vec/columns/column_dictionary.h"
-#include "vec/columns/column_nullable.h"
-#include "vec/columns/column_vector.h"
-#include "vec/columns/predicate_column.h"
-#include "vec/exprs/vruntimefilter_wrapper.h"
-
-namespace doris {
-
-// only use in runtime filter and segment v2
-
-template <PrimitiveType T>
-class BloomFilterColumnPredicate : public ColumnPredicate {
-public:
- using SpecificFilter = BloomFilterFunc<T>;
-
- BloomFilterColumnPredicate(uint32_t column_id,
- const std::shared_ptr<BloomFilterFuncBase>&
filter,
- int be_exec_version)
- : ColumnPredicate(column_id),
- _filter(filter),
-
_specific_filter(reinterpret_cast<SpecificFilter*>(_filter.get())),
- _be_exec_version(be_exec_version) {}
- ~BloomFilterColumnPredicate() override = default;
-
- PredicateType type() const override { return PredicateType::BF; }
-
- Status evaluate(BitmapIndexIterator* iterators, uint32_t num_rows,
- roaring::Roaring* roaring) const override {
- return Status::OK();
- }
-
- uint16_t evaluate(const vectorized::IColumn& column, uint16_t* sel,
- uint16_t size) const override;
-
-private:
- template <bool is_nullable>
- uint16_t evaluate(const vectorized::IColumn& column, const uint8_t*
null_map, uint16_t* sel,
- uint16_t size) const {
- if constexpr (is_nullable) {
- DCHECK(null_map);
- }
-
- uint24_t tmp_uint24_value;
- auto get_cell_value = [&tmp_uint24_value](auto& data) {
- if constexpr (std::is_same_v<std::decay_t<decltype(data)>,
uint32_t> &&
- T == PrimitiveType::TYPE_DATE) {
- memcpy((char*)(&tmp_uint24_value), (char*)(&data),
sizeof(uint24_t));
- return (const char*)&tmp_uint24_value;
- } else {
- return (const char*)&data;
- }
- };
-
- uint16_t new_size = 0;
- if (column.is_column_dictionary()) {
- auto* dict_col = reinterpret_cast<const
vectorized::ColumnDictI32*>(&column);
- if (_be_exec_version >= 2) {
- for (uint16_t i = 0; i < size; i++) {
- uint16_t idx = sel[i];
- sel[new_size] = idx;
- if constexpr (is_nullable) {
- new_size += !null_map[idx] &&
_specific_filter->find_uint32_t(
-
dict_col->get_crc32_hash_value(idx));
- } else {
- new_size += _specific_filter->find_uint32_t(
- dict_col->get_crc32_hash_value(idx));
- }
- }
- } else {
- for (uint16_t i = 0; i < size; i++) {
- uint16_t idx = sel[i];
- sel[new_size] = idx;
- if constexpr (is_nullable) {
- new_size += !null_map[idx] &&
-
_specific_filter->find_uint32_t(dict_col->get_hash_value(idx));
- } else {
- new_size +=
_specific_filter->find_uint32_t(dict_col->get_hash_value(idx));
- }
- }
- }
- } else if (is_string_type(T) && _be_exec_version >= 2) {
- auto& pred_col =
- reinterpret_cast<
- const
vectorized::PredicateColumnType<PredicateEvaluateType<T>>*>(
- &column)
- ->get_data();
-
- auto pred_col_data = pred_col.data();
- const bool is_dense_column = pred_col.size() == size;
- for (uint16_t i = 0; i < size; i++) {
- uint16_t idx = is_dense_column ? i : sel[i];
- if constexpr (is_nullable) {
- if (!null_map[idx] &&
-
_specific_filter->find_crc32_hash(get_cell_value(pred_col_data[idx]))) {
- sel[new_size++] = idx;
- }
- } else {
- if
(_specific_filter->find_crc32_hash(get_cell_value(pred_col_data[idx]))) {
- sel[new_size++] = idx;
- }
- }
- }
- } else if (IRuntimeFilter::enable_use_batch(_be_exec_version > 0, T)) {
- const auto& data =
- reinterpret_cast<
- const
vectorized::PredicateColumnType<PredicateEvaluateType<T>>*>(
- &column)
- ->get_data();
- new_size =
_specific_filter->find_fixed_len_olap_engine((char*)data.data(), null_map,
- sel, size,
data.size() != size);
- } else {
- auto& pred_col =
- reinterpret_cast<
- const
vectorized::PredicateColumnType<PredicateEvaluateType<T>>*>(
- &column)
- ->get_data();
-
- auto pred_col_data = pred_col.data();
-#define EVALUATE_WITH_NULL_IMPL(IDX) \
- !null_map[IDX] &&
_specific_filter->find_olap_engine(get_cell_value(pred_col_data[IDX]))
-#define EVALUATE_WITHOUT_NULL_IMPL(IDX) \
- _specific_filter->find_olap_engine(get_cell_value(pred_col_data[IDX]))
- EVALUATE_BY_SELECTOR(EVALUATE_WITH_NULL_IMPL,
EVALUATE_WITHOUT_NULL_IMPL)
-#undef EVALUATE_WITH_NULL_IMPL
-#undef EVALUATE_WITHOUT_NULL_IMPL
- }
- return new_size;
- }
-
- std::string _debug_string() const override {
- std::string info = "BloomFilterColumnPredicate(" + type_to_string(T) +
")";
- return info;
- }
-
- int get_filter_id() const override {
- int filter_id = _filter->get_filter_id();
- DCHECK(filter_id != -1);
- return filter_id;
- }
- bool is_filter() const override { return true; }
-
- std::shared_ptr<BloomFilterFuncBase> _filter;
- SpecificFilter* _specific_filter; // owned by _filter
- mutable bool _always_true = false;
- mutable bool _has_calculate_filter = false;
- int _be_exec_version;
-};
-
-template <PrimitiveType T>
-uint16_t BloomFilterColumnPredicate<T>::evaluate(const vectorized::IColumn&
column, uint16_t* sel,
- uint16_t size) const {
- uint16_t new_size = 0;
- if (_always_true) {
- return size;
- }
- if (column.is_nullable()) {
- auto* nullable_col = reinterpret_cast<const
vectorized::ColumnNullable*>(&column);
- auto& null_map_data = nullable_col->get_null_map_column().get_data();
- new_size =
- evaluate<true>(nullable_col->get_nested_column(),
null_map_data.data(), sel, size);
- } else {
- new_size = evaluate<false>(column, nullptr, sel, size);
- }
- // If the pass rate is very high, for example > 50%, then the bloomfilter
is useless.
- // Some bloomfilter is useless, for example ssb 4.3, it consumes a lot of
cpu but it is
- // useless.
- _evaluated_rows += size;
- _passed_rows += new_size;
- vectorized::VRuntimeFilterWrapper::calculate_filter(
- _evaluated_rows - _passed_rows, _evaluated_rows,
_has_calculate_filter, _always_true);
- return new_size;
-}
-
-} //namespace doris
diff --git a/be/src/olap/olap_common.h b/be/src/olap/olap_common.h
index 07a6d296481..78ff8dd82f1 100644
--- a/be/src/olap/olap_common.h
+++ b/be/src/olap/olap_common.h
@@ -312,6 +312,7 @@ struct OlapReaderStatistics {
int64_t rows_vec_cond_filtered = 0;
int64_t rows_short_circuit_cond_filtered = 0;
+ int64_t rows_common_expr_filtered = 0;
int64_t vec_cond_input_rows = 0;
int64_t short_circuit_cond_input_rows = 0;
int64_t rows_vec_del_cond_filtered = 0;
diff --git a/be/src/olap/predicate_creator.h b/be/src/olap/predicate_creator.h
index 742336ec777..efe92c6dbd2 100644
--- a/be/src/olap/predicate_creator.h
+++ b/be/src/olap/predicate_creator.h
@@ -23,7 +23,6 @@
#include "exec/olap_utils.h"
#include "exprs/create_predicate_function.h"
#include "exprs/hybrid_set.h"
-#include "olap/bloom_filter_predicate.h"
#include "olap/column_predicate.h"
#include "olap/comparison_predicate.h"
#include "olap/in_list_predicate.h"
diff --git a/be/src/olap/reader.cpp b/be/src/olap/reader.cpp
index e571b9d1c32..eab24a8ea81 100644
--- a/be/src/olap/reader.cpp
+++ b/be/src/olap/reader.cpp
@@ -490,11 +490,6 @@ Status TabletReader::_init_conditions_param(const
ReaderParams& read_params) {
}
}
- // Only key column bloom filter will push down to storage engine
- for (const auto& filter : read_params.bloom_filters) {
- _col_predicates.emplace_back(_parse_to_predicate(filter));
- }
-
for (const auto& filter : read_params.bitmap_filters) {
_col_predicates.emplace_back(_parse_to_predicate(filter));
}
@@ -568,17 +563,6 @@ void
TabletReader::_init_conditions_param_except_leafnode_of_andnode(
}
}
-ColumnPredicate* TabletReader::_parse_to_predicate(
- const std::pair<std::string, std::shared_ptr<BloomFilterFuncBase>>&
bloom_filter) {
- int32_t index = _tablet_schema->field_index(bloom_filter.first);
- if (index < 0) {
- return nullptr;
- }
- const TabletColumn& column = _tablet_schema->column(index);
- return create_column_predicate(index, bloom_filter.second, column.type(),
-
_reader_context.runtime_state->be_exec_version(), &column);
-}
-
ColumnPredicate* TabletReader::_parse_to_predicate(
const std::pair<std::string, std::shared_ptr<HybridSetBase>>&
in_filter) {
int32_t index = _tablet_schema->field_index(in_filter.first);
diff --git a/be/src/olap/reader.h b/be/src/olap/reader.h
index b0d5ed1fa28..11806f5ca9c 100644
--- a/be/src/olap/reader.h
+++ b/be/src/olap/reader.h
@@ -240,9 +240,6 @@ protected:
void _init_conditions_param_except_leafnode_of_andnode(const ReaderParams&
read_params);
- ColumnPredicate* _parse_to_predicate(
- const std::pair<std::string,
std::shared_ptr<BloomFilterFuncBase>>& bloom_filter);
-
ColumnPredicate* _parse_to_predicate(
const std::pair<std::string,
std::shared_ptr<BitmapFilterFuncBase>>& bitmap_filter);
diff --git a/be/src/olap/rowset/segment_v2/segment_iterator.cpp
b/be/src/olap/rowset/segment_v2/segment_iterator.cpp
index b5e7aa7d4bf..a86d1681442 100644
--- a/be/src/olap/rowset/segment_v2/segment_iterator.cpp
+++ b/be/src/olap/rowset/segment_v2/segment_iterator.cpp
@@ -38,7 +38,6 @@
#include "common/object_pool.h"
#include "common/status.h"
#include "io/io_common.h"
-#include "olap/bloom_filter_predicate.h"
#include "olap/column_predicate.h"
#include "olap/field.h"
#include "olap/iterators.h"
@@ -2059,7 +2058,9 @@ Status SegmentIterator::_execute_common_expr(uint16_t*
sel_rowid_idx, uint16_t&
RETURN_IF_ERROR(vectorized::VExprContext::execute_conjuncts_and_filter_block(
_common_expr_ctxs_push_down, block, _columns_to_filter,
prev_columns, filter));
+ const auto origin_size = selected_size;
selected_size = _evaluate_common_expr_filter(sel_rowid_idx, selected_size,
filter);
+ _opts.stats->rows_common_expr_filtered += (origin_size - selected_size);
return Status::OK();
}
diff --git a/be/src/pipeline/exec/olap_scan_operator.cpp
b/be/src/pipeline/exec/olap_scan_operator.cpp
index b66157d567f..785e2c0aa17 100644
--- a/be/src/pipeline/exec/olap_scan_operator.cpp
+++ b/be/src/pipeline/exec/olap_scan_operator.cpp
@@ -72,6 +72,8 @@ Status OlapScanLocalState::_init_profile() {
ADD_COUNTER(_segment_profile, "RowsVectorPredInput", TUnit::UNIT);
_rows_short_circuit_cond_input_counter =
ADD_COUNTER(_segment_profile, "RowsShortCircuitPredInput",
TUnit::UNIT);
+ _rows_common_expr_filtered_counter =
+ ADD_COUNTER(_segment_profile, "RowsCommonExprFiltered",
TUnit::UNIT);
_vec_cond_timer = ADD_TIMER(_segment_profile, "VectorPredEvalTime");
_short_cond_timer = ADD_TIMER(_segment_profile, "ShortPredEvalTime");
_expr_filter_timer = ADD_TIMER(_segment_profile, "ExprFilterEvalTime");
diff --git a/be/src/pipeline/exec/olap_scan_operator.h
b/be/src/pipeline/exec/olap_scan_operator.h
index 0527fa6f44d..d3c66581393 100644
--- a/be/src/pipeline/exec/olap_scan_operator.h
+++ b/be/src/pipeline/exec/olap_scan_operator.h
@@ -114,6 +114,7 @@ private:
RuntimeProfile::Counter* _rows_short_circuit_cond_filtered_counter =
nullptr;
RuntimeProfile::Counter* _rows_vec_cond_input_counter = nullptr;
RuntimeProfile::Counter* _rows_short_circuit_cond_input_counter = nullptr;
+ RuntimeProfile::Counter* _rows_common_expr_filtered_counter = nullptr;
RuntimeProfile::Counter* _vec_cond_timer = nullptr;
RuntimeProfile::Counter* _short_cond_timer = nullptr;
RuntimeProfile::Counter* _expr_filter_timer = nullptr;
diff --git a/be/src/pipeline/exec/scan_operator.cpp
b/be/src/pipeline/exec/scan_operator.cpp
index 601bf5b8b9f..4a1d5124005 100644
--- a/be/src/pipeline/exec/scan_operator.cpp
+++ b/be/src/pipeline/exec/scan_operator.cpp
@@ -356,9 +356,6 @@ Status ScanLocalState<Derived>::_normalize_predicate(
RETURN_IF_PUSH_DOWN(
_normalize_bitmap_filter(cur_expr,
context, slot, &pdt),
status);
- RETURN_IF_PUSH_DOWN(
- _normalize_bloom_filter(cur_expr,
context, slot, &pdt),
- status);
if (state()->enable_function_pushdown()) {
RETURN_IF_PUSH_DOWN(_normalize_function_filters(
cur_expr,
context, slot, &pdt),
@@ -431,23 +428,6 @@ Status ScanLocalState<Derived>::_normalize_predicate(
return Status::OK();
}
-template <typename Derived>
-Status ScanLocalState<Derived>::_normalize_bloom_filter(vectorized::VExpr*
expr,
-
vectorized::VExprContext* expr_ctx,
- SlotDescriptor* slot,
-
vectorized::VScanNode::PushDownType* pdt) {
- if (TExprNodeType::BLOOM_PRED == expr->node_type()) {
- DCHECK(expr->children().size() == 1);
- vectorized::VScanNode::PushDownType temp_pdt =
_should_push_down_bloom_filter();
- if (temp_pdt != vectorized::VScanNode::PushDownType::UNACCEPTABLE) {
- _filter_predicates.bloom_filters.emplace_back(slot->col_name(),
-
expr->get_bloom_filter_func());
- *pdt = temp_pdt;
- }
- }
- return Status::OK();
-}
-
template <typename Derived>
Status ScanLocalState<Derived>::_normalize_bitmap_filter(vectorized::VExpr*
expr,
vectorized::VExprContext* expr_ctx,
diff --git a/be/src/pipeline/exec/scan_operator.h
b/be/src/pipeline/exec/scan_operator.h
index 68d006006f6..8ee9b4b5b40 100644
--- a/be/src/pipeline/exec/scan_operator.h
+++ b/be/src/pipeline/exec/scan_operator.h
@@ -287,9 +287,6 @@ protected:
Status _eval_const_conjuncts(vectorized::VExpr* vexpr,
vectorized::VExprContext* expr_ctx,
vectorized::VScanNode::PushDownType* pdt);
- Status _normalize_bloom_filter(vectorized::VExpr* expr,
vectorized::VExprContext* expr_ctx,
- SlotDescriptor* slot,
vectorized::VScanNode::PushDownType* pdt);
-
Status _normalize_bitmap_filter(vectorized::VExpr* expr,
vectorized::VExprContext* expr_ctx,
SlotDescriptor* slot,
vectorized::VScanNode::PushDownType* pdt);
diff --git a/be/src/vec/exec/scan/new_olap_scan_node.cpp
b/be/src/vec/exec/scan/new_olap_scan_node.cpp
index b7b3c5b7f7c..fca98e5f766 100644
--- a/be/src/vec/exec/scan/new_olap_scan_node.cpp
+++ b/be/src/vec/exec/scan/new_olap_scan_node.cpp
@@ -134,6 +134,8 @@ Status NewOlapScanNode::_init_profile() {
ADD_COUNTER(_segment_profile, "RowsVectorPredInput", TUnit::UNIT);
_rows_short_circuit_cond_input_counter =
ADD_COUNTER(_segment_profile, "RowsShortCircuitPredInput",
TUnit::UNIT);
+ _rows_common_expr_filtered_counter =
+ ADD_COUNTER(_segment_profile, "RowsCommonExprFiltered",
TUnit::UNIT);
_vec_cond_timer = ADD_TIMER(_segment_profile, "VectorPredEvalTime");
_short_cond_timer = ADD_TIMER(_segment_profile, "ShortPredEvalTime");
_expr_filter_timer = ADD_TIMER(_segment_profile, "ExprFilterEvalTime");
diff --git a/be/src/vec/exec/scan/new_olap_scan_node.h
b/be/src/vec/exec/scan/new_olap_scan_node.h
index 93039c6182a..7a25d743c4c 100644
--- a/be/src/vec/exec/scan/new_olap_scan_node.h
+++ b/be/src/vec/exec/scan/new_olap_scan_node.h
@@ -138,6 +138,7 @@ private:
RuntimeProfile::Counter* _rows_short_circuit_cond_filtered_counter =
nullptr;
RuntimeProfile::Counter* _rows_vec_cond_input_counter = nullptr;
RuntimeProfile::Counter* _rows_short_circuit_cond_input_counter = nullptr;
+ RuntimeProfile::Counter* _rows_common_expr_filtered_counter = nullptr;
RuntimeProfile::Counter* _vec_cond_timer = nullptr;
RuntimeProfile::Counter* _short_cond_timer = nullptr;
RuntimeProfile::Counter* _expr_filter_timer = nullptr;
diff --git a/be/src/vec/exec/scan/new_olap_scanner.cpp
b/be/src/vec/exec/scan/new_olap_scanner.cpp
index 980ee5b4cea..7992ab1a456 100644
--- a/be/src/vec/exec/scan/new_olap_scanner.cpp
+++ b/be/src/vec/exec/scan/new_olap_scanner.cpp
@@ -553,6 +553,7 @@ void NewOlapScanner::_update_counters_before_close() {
COUNTER_UPDATE(Parent->_rows_vec_cond_input_counter,
stats.vec_cond_input_rows); \
COUNTER_UPDATE(Parent->_rows_short_circuit_cond_input_counter,
\
stats.short_circuit_cond_input_rows);
\
+ COUNTER_UPDATE(Parent->_rows_common_expr_filtered_counter,
stats.rows_common_expr_filtered); \
for (auto& [id, info] : stats.filter_info) {
\
Parent->add_filter_info(id, info);
\
}
\
diff --git a/be/src/vec/exec/scan/vscan_node.cpp
b/be/src/vec/exec/scan/vscan_node.cpp
index b743de4b141..0fb60b73d04 100644
--- a/be/src/vec/exec/scan/vscan_node.cpp
+++ b/be/src/vec/exec/scan/vscan_node.cpp
@@ -524,9 +524,6 @@ Status VScanNode::_normalize_predicate(const VExprSPtr&
conjunct_expr_root, VExp
RETURN_IF_PUSH_DOWN(
_normalize_bitmap_filter(cur_expr,
context, slot, &pdt),
status);
- RETURN_IF_PUSH_DOWN(
- _normalize_bloom_filter(cur_expr,
context, slot, &pdt),
- status);
if (_state->enable_function_pushdown()) {
RETURN_IF_PUSH_DOWN(_normalize_function_filters(
cur_expr,
context, slot, &pdt),
@@ -599,20 +596,6 @@ Status VScanNode::_normalize_predicate(const VExprSPtr&
conjunct_expr_root, VExp
return Status::OK();
}
-Status VScanNode::_normalize_bloom_filter(VExpr* expr, VExprContext* expr_ctx,
SlotDescriptor* slot,
- PushDownType* pdt) {
- if (TExprNodeType::BLOOM_PRED == expr->node_type()) {
- DCHECK(expr->children().size() == 1);
- PushDownType temp_pdt = _should_push_down_bloom_filter();
- if (temp_pdt != PushDownType::UNACCEPTABLE) {
- _filter_predicates.bloom_filters.emplace_back(slot->col_name(),
-
expr->get_bloom_filter_func());
- *pdt = temp_pdt;
- }
- }
- return Status::OK();
-}
-
Status VScanNode::_normalize_bitmap_filter(VExpr* expr, VExprContext* expr_ctx,
SlotDescriptor* slot, PushDownType*
pdt) {
if (TExprNodeType::BITMAP_PRED == expr->node_type()) {
diff --git a/be/src/vec/exec/scan/vscan_node.h
b/be/src/vec/exec/scan/vscan_node.h
index 73961f59133..5110ce18ac3 100644
--- a/be/src/vec/exec/scan/vscan_node.h
+++ b/be/src/vec/exec/scan/vscan_node.h
@@ -365,9 +365,6 @@ private:
VExprSPtr& output_expr);
Status _eval_const_conjuncts(VExpr* vexpr, VExprContext* expr_ctx,
PushDownType* pdt);
- Status _normalize_bloom_filter(VExpr* expr, VExprContext* expr_ctx,
SlotDescriptor* slot,
- PushDownType* pdt);
-
Status _normalize_bitmap_filter(VExpr* expr, VExprContext* expr_ctx,
SlotDescriptor* slot,
PushDownType* pdt);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
