github-actions[bot] commented on code in PR #26534:
URL: https://github.com/apache/doris/pull/26534#discussion_r1384793847
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##########
@@ -61,5 +62,31 @@ Status DataTypeIPv4SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeIPv4SerDe::serialize_one_cell_to_json(const IColumn& column,
int row_num,
Review Comment:
warning: method 'serialize_one_cell_to_json' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DataTypeIPv4SerDe::serialize_one_cell_to_json(const IColumn&
column, int row_num,
```
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:66:
```diff
- FormatOptions&
options) const {
+ FormatOptions&
options) {
```
##########
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:
##########
@@ -61,5 +62,31 @@ Status DataTypeIPv6SerDe::write_column_to_mysql(const
IColumn& column,
return _write_column_to_mysql(column, row_buffer, row_idx, col_const);
}
+Status DataTypeIPv6SerDe::serialize_one_cell_to_json(const IColumn& column,
int row_num,
Review Comment:
warning: method 'serialize_one_cell_to_json' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DataTypeIPv6SerDe::serialize_one_cell_to_json(const IColumn&
column, int row_num,
```
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:66:
```diff
- FormatOptions&
options) const {
+ FormatOptions&
options) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
