morningman commented on a change in pull request #5329:
URL: https://github.com/apache/incubator-doris/pull/5329#discussion_r569460268
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -6811,5 +6820,67 @@ private void setReplicaStatusInternal(long tabletId,
long backendId, ReplicaStat
table.writeUnlock();
}
}
+
+ public void eraseDatabase(long dbId, boolean needEditLog) {
Review comment:
```suggestion
public void onEraseDatabase(long dbId, boolean needEditLog) {
```
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -6811,5 +6820,67 @@ private void setReplicaStatusInternal(long tabletId,
long backendId, ReplicaStat
table.writeUnlock();
}
}
+
+ public void eraseDatabase(long dbId, boolean needEditLog) {
+ // remove jobs
+ Catalog.getCurrentCatalog().getLoadInstance().removeDbLoadJob(dbId);
Review comment:
I think we don't need to call these `removeXXXJobs` functions. Because
these jobs will be cancelled automatically when it find that database does not
exist anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
