github-actions[bot] commented on code in PR #26760:
URL: https://github.com/apache/doris/pull/26760#discussion_r1389148559
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -48,15 +48,15 @@ using std::vector;
namespace doris {
using namespace ErrorCode;
-Status TabletMeta::create(const TCreateTabletReq& request, const TabletUid&
tablet_uid,
- uint64_t shard_id, uint32_t next_unique_id,
- const unordered_map<uint32_t, uint32_t>&
col_ordinal_to_unique_id,
- TabletMetaSharedPtr* tablet_meta) {
+TabletMetaSharedPtr TabletMeta::create(
Review Comment:
warning: method 'create' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static TabletMetaSharedPtr TabletMeta::create(
```
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -48,15 +48,15 @@
namespace doris {
using namespace ErrorCode;
-Status TabletMeta::create(const TCreateTabletReq& request, const TabletUid&
tablet_uid,
- uint64_t shard_id, uint32_t next_unique_id,
- const unordered_map<uint32_t, uint32_t>&
col_ordinal_to_unique_id,
- TabletMetaSharedPtr* tablet_meta) {
+TabletMetaSharedPtr TabletMeta::create(
+ const TCreateTabletReq& request, const TabletUid& tablet_uid, uint64_t
shard_id,
+ uint32_t next_unique_id,
+ const unordered_map<uint32_t, uint32_t>& col_ordinal_to_unique_id) {
Review Comment:
warning: all parameters should be named in a function
[readability-named-parameter]
```suggestion
const /*unused*/unordered_map<uint32_t, uint32_t>&
col_ordinal_to_unique_id) {
```
##########
be/src/olap/tablet_meta.h:
##########
@@ -91,10 +91,10 @@ class TBinlogConfig;
// The concurrency control is handled in Tablet Class, not in this class.
class TabletMeta {
public:
- static Status create(const TCreateTabletReq& request, const TabletUid&
tablet_uid,
- uint64_t shard_id, uint32_t next_unique_id,
- const std::unordered_map<uint32_t, uint32_t>&
col_ordinal_to_unique_id,
- TabletMetaSharedPtr* tablet_meta);
+ static TabletMetaSharedPtr create(
+ const TCreateTabletReq& request, const TabletUid& tablet_uid,
uint64_t shard_id,
+ uint32_t next_unique_id,
+ const std::unordered_map<uint32_t, uint32_t>&
col_ordinal_to_unique_id);
Review Comment:
warning: parameter 5 is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
std::unordered_map<uint32_t, uint32_t>&
col_ordinal_to_unique_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
