github-actions[bot] commented on code in PR #26784:
URL: https://github.com/apache/doris/pull/26784#discussion_r1389391979


##########
be/src/util/blocking_queue.hpp:
##########
@@ -136,6 +157,8 @@
     std::list<T> _list;
     std::atomic<uint64_t> _total_get_wait_time;
     std::atomic<uint64_t> _total_put_wait_time;
+    size_t _get_waiting;
+    size_t _put_waiting;

Review Comment:
   warning: use default member initializer for '_put_waiting' 
[modernize-use-default-member-init]
   
   be/src/util/blocking_queue.hpp:45:
   ```diff
   -               _put_waiting(0) {}
   +               {}
   ```
   
   ```suggestion
       size_t _put_waiting{0};
   ```
   



##########
be/src/util/blocking_queue.hpp:
##########
@@ -136,6 +157,8 @@ class BlockingQueue {
     std::list<T> _list;
     std::atomic<uint64_t> _total_get_wait_time;
     std::atomic<uint64_t> _total_put_wait_time;
+    size_t _get_waiting;

Review Comment:
   warning: use default member initializer for '_get_waiting' 
[modernize-use-default-member-init]
   
   be/src/util/blocking_queue.hpp:44:
   ```diff
   -               _get_waiting(0),
   +               ,
   ```
   
   ```suggestion
       size_t _get_waiting{0};
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to