dataroaring commented on code in PR #24403:
URL: https://github.com/apache/doris/pull/24403#discussion_r1390035144
##########
be/src/olap/rowset/segment_creator.cpp:
##########
@@ -81,6 +82,21 @@ Status
SegmentFlusher::_add_rows(std::unique_ptr<segment_v2::SegmentWriter>& seg
return Status::OK();
}
+Status
SegmentFlusher::_add_rows(std::unique_ptr<segment_v2::VerticalSegmentWriter>&
segment_writer,
+ const vectorized::Block* block, size_t
row_offset,
+ size_t row_num) {
+ Status s = segment_writer->batch_block(block, row_offset, row_num);
+ if (UNLIKELY(!s.ok())) {
+ return Status::Error<WRITER_DATA_WRITE_ERROR>("failed to append block:
{}", s.to_string());
Review Comment:
We should export real status to upp layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
