Jibing-Li commented on code in PR #26435:
URL: https://github.com/apache/doris/pull/26435#discussion_r1390552180
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java:
##########
@@ -174,30 +174,33 @@ public static ColumnStatistic fromResultRow(ResultRow
row) {
String min = row.get(10);
String max = row.get(11);
if (min != null && !min.equalsIgnoreCase("NULL")) {
- min = new String(Base64.getDecoder().decode(min),
- StandardCharsets.UTF_8);
-
- try {
-
columnStatisticBuilder.setMinValue(StatisticsUtil.convertToDouble(col.getType(),
min));
-
columnStatisticBuilder.setMinExpr(StatisticsUtil.readableValue(col.getType(),
min));
- } catch (AnalysisException e) {
- LOG.warn("Failed to deserialize column {} min value {}.",
col, min, e);
+ min = new String(Base64.getDecoder().decode(min),
StandardCharsets.UTF_8);
+ if (catalogId != 0 && min.equalsIgnoreCase("NULL")) {
Review Comment:
Yes, this to check is an internal catalog or not. Internal catalog get the
min/max value using a separate SQL, and the value is already encoded by base64.
Need to handle internal and external catalog separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
