This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new d9e0a9fa2e8 [enhancement](230) print max version and spec version when
-230 happens (#26643)
d9e0a9fa2e8 is described below
commit d9e0a9fa2e85a44b15fdf55641c5a711e40fd999
Author: Yongqiang YANG <[email protected]>
AuthorDate: Mon Nov 13 09:57:22 2023 +0800
[enhancement](230) print max version and spec version when -230 happens
(#26643)
More information is provided.
---
be/src/olap/tablet.cpp | 8 ++++++--
be/src/vec/exec/scan/new_olap_scanner.cpp | 4 +---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp
index f2037e1af7b..cfd71abff14 100644
--- a/be/src/olap/tablet.cpp
+++ b/be/src/olap/tablet.cpp
@@ -874,9 +874,13 @@ Status Tablet::capture_consistent_versions(const Version&
spec_version,
// so to avoid print too many logs.
if (version_path != nullptr) {
LOG(WARNING) << "tablet:" << tablet_id()
- << ", version already has been merged.
spec_version: " << spec_version;
+ << ", version already has been merged.
spec_version: " << spec_version
+ << ", max_version: " << max_version_unlocked();
}
- status = Status::Error<VERSION_ALREADY_MERGED>("missed_versions is
empty");
+ status = Status::Error<VERSION_ALREADY_MERGED>(
+ "missed_versions is empty, spec_version "
+ "{}, max_version {}, tablet_id {}",
+ spec_version.second, max_version_unlocked().second,
tablet_id());
} else {
if (version_path != nullptr) {
LOG(WARNING) << "status:" << status << ", tablet:" <<
tablet_id()
diff --git a/be/src/vec/exec/scan/new_olap_scanner.cpp
b/be/src/vec/exec/scan/new_olap_scanner.cpp
index 7992ab1a456..0726c71e45d 100644
--- a/be/src/vec/exec/scan/new_olap_scanner.cpp
+++ b/be/src/vec/exec/scan/new_olap_scanner.cpp
@@ -186,9 +186,7 @@ Status NewOlapScanner::init() {
_state->skip_missing_version());
if (!st.ok()) {
LOG(WARNING) << "fail to init reader.res=" << st;
- return Status::InternalError(
- "failed to initialize storage reader. tablet_id={}
: {}",
- tablet->tablet_id(), st.to_string());
+ return st;
}
}
if (!_state->skip_delete_predicate()) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
