wuyunfeng commented on a change in pull request #5325:
URL: https://github.com/apache/incubator-doris/pull/5325#discussion_r581721359
##########
File path: be/src/exec/es/es_scan_reader.h
##########
@@ -63,6 +64,8 @@ class ESScanReader {
std::string _query;
// Elasticsearch shards to fetch document
std::string _shards;
+ // whether use ssl client
+ bool _use_ssl_client;
Review comment:
init `_use_ssl_client`?
##########
File path: be/src/http/http_client.h
##########
@@ -66,6 +66,11 @@ class HttpClient {
curl_easy_setopt(_curl, CURLOPT_COPYPOSTFIELDS, post_body.c_str());
}
+ void use_ssl() {
+ curl_easy_setopt(_curl, CURLOPT_SSL_VERIFYPEER, false);
Review comment:
The third param should be a long type ??
##########
File path: be/src/exec/es/es_scan_reader.cpp
##########
@@ -134,6 +140,9 @@ Status ESScanReader::get_next(bool* scan_eos,
std::unique_ptr<ScrollParser>& scr
_network_client.set_basic_auth(_user_name, _passwd);
_network_client.set_content_type("application/json");
_network_client.set_timeout_ms(_http_timeout_ms);
+ if (_use_ssl_client) {
Review comment:
put line 143 and 111 together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
