github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1390686462
##########
be/src/vec/data_types/data_type_ipv4.h:
##########
@@ -50,6 +51,10 @@ class DataTypeIPv4 final : public DataTypeNumberBase<IPv4> {
const char* get_family_name() const override { return "IPv4"; }
std::string do_get_name() const override { return "IPv4"; }
+ doris::FieldType get_storage_field_type() const override {
Review Comment:
warning: method 'get_storage_field_type' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static doris::FieldType get_storage_field_type() override {
```
##########
be/src/vec/data_types/data_type_ipv6.h:
##########
@@ -48,6 +48,9 @@ class DataTypeIPv6 final : public DataTypeNumberBase<IPv6> {
TPrimitiveType::type get_type_as_tprimitive_type() const override {
return TPrimitiveType::IPV6;
}
+ doris::FieldType get_storage_field_type() const override {
Review Comment:
warning: method 'get_storage_field_type' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static doris::FieldType get_storage_field_type() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
