JNSimba commented on code in PR #226:
URL:
https://github.com/apache/doris-flink-connector/pull/226#discussion_r1391978813
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/LabelGenerator.java:
##########
@@ -43,20 +45,31 @@ public LabelGenerator(String labelPrefix, boolean
enable2PC, String tableIdentif
public String generateLabel(long chkId) {
String label = String.format("%s_%s_%s", labelPrefix, subtaskId,
chkId);
- return enable2PC ? label : label + "_" + UUID.randomUUID();
+ String result = enable2PC ? label : label + "_" + UUID.randomUUID();
+ return generateLabelUtil(result);
}
public String generateTableLabel(long chkId) {
Preconditions.checkState(tableIdentifier != null);
String label = String.format("%s_%s_%s_%s", labelPrefix,
tableIdentifier, subtaskId, chkId);
- return enable2PC ? label : label + "_" + UUID.randomUUID();
+ String result = enable2PC ? label : label + "_" + UUID.randomUUID();
+ return generateLabelUtil(result);
}
public String generateBatchLabel() {
- return labelPrefix + "_" + UUID.randomUUID();
+ return generateLabelUtil(labelPrefix + "_" + UUID.randomUUID());
}
public String generateBatchLabel(String table) {
- return String.format("%s_%s_%s", labelPrefix, table,
UUID.randomUUID());
+ return generateLabelUtil(String.format("%s_%s_%s", labelPrefix, table,
UUID.randomUUID()));
+ }
+
+ public String generateLabelUtil(String label) {
Review Comment:
please add unit test ，thanks
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/LabelGenerator.java:
##########
@@ -43,20 +45,31 @@ public LabelGenerator(String labelPrefix, boolean
enable2PC, String tableIdentif
public String generateLabel(long chkId) {
String label = String.format("%s_%s_%s", labelPrefix, subtaskId,
chkId);
- return enable2PC ? label : label + "_" + UUID.randomUUID();
+ String result = enable2PC ? label : label + "_" + UUID.randomUUID();
+ return generateLabelUtil(result);
}
public String generateTableLabel(long chkId) {
Preconditions.checkState(tableIdentifier != null);
String label = String.format("%s_%s_%s_%s", labelPrefix,
tableIdentifier, subtaskId, chkId);
- return enable2PC ? label : label + "_" + UUID.randomUUID();
+ String result = enable2PC ? label : label + "_" + UUID.randomUUID();
+ return generateLabelUtil(result);
}
public String generateBatchLabel() {
- return labelPrefix + "_" + UUID.randomUUID();
+ return generateLabelUtil(labelPrefix + "_" + UUID.randomUUID());
}
public String generateBatchLabel(String table) {
- return String.format("%s_%s_%s", labelPrefix, table,
UUID.randomUUID());
+ return generateLabelUtil(String.format("%s_%s_%s", labelPrefix, table,
UUID.randomUUID()));
+ }
+
+ public String generateLabelUtil(String label) {
Review Comment:
please add unit test ，thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
