github-actions[bot] commented on code in PR #26984:
URL: https://github.com/apache/doris/pull/26984#discussion_r1392540198
##########
be/src/olap/olap_server.cpp:
##########
@@ -1022,11 +1022,13 @@ void StorageEngine::_cooldown_tasks_producer_callback()
{
// also tablets once failed to do follow cooldown
auto skip_tablet = [this, skip_failed_interval,
cur_time](const TabletSharedPtr& tablet) -> bool {
+ bool is_skip =
+ cur_time - tablet->last_failed_follow_cooldown_time() <
skip_failed_interval ||
+ TABLET_RUNNING != tablet->tablet_state();
+ if (is_skip) return is_skip;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (is_skip) { return is_skip;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
