yiguolei commented on code in PR #26978:
URL: https://github.com/apache/doris/pull/26978#discussion_r1392550028
##########
be/src/vec/sink/load_stream_stub.cpp:
##########
@@ -108,6 +108,10 @@ LoadStreamStub::LoadStreamStub(LoadStreamStub& stub)
LoadStreamStub::~LoadStreamStub() {
if (_is_init.load() && !_handler.is_closed()) {
brpc::StreamClose(_stream_id);
+ auto st = close_wait(60000); // timeout 60s
Review Comment:
why do we need wait in an deconstructor method??
I think we should call wait using a explicit method call and then call dector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
