github-actions[bot] commented on code in PR #26761:
URL: https://github.com/apache/doris/pull/26761#discussion_r1392907131
##########
be/src/vec/common/hash_table/hash_map.h:
##########
@@ -434,11 +472,11 @@ class JoinHashMapTable : public HashMapTable<Key, Cell,
Hash, Grower, Allocator>
const Key* __restrict build_keys;
std::vector<uint8_t> visited;
- uint32_t bucket_size = 0;
- int max_batch_size = 0;
+ uint32_t bucket_size = 1;
+ int max_batch_size = 4064;
- std::vector<uint32_t> first;
- std::vector<uint32_t> next;
+ std::vector<uint32_t> first = {0};
+ std::vector<uint32_t> next = {0};
Review Comment:
warning: 4064 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
int max_batch_size = 4064;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
