yangzhg commented on a change in pull request #5425:
URL: https://github.com/apache/incubator-doris/pull/5425#discussion_r586985037
##########
File path: be/src/olap/hll.cpp
##########
@@ -164,7 +164,7 @@ size_t HyperLogLog::serialize(uint8_t* dst) const {
break;
}
case HLL_DATA_EXPLICIT: {
- DCHECK(_hash_set.size() < HLL_EXPLICIT_INT64_NUM)
+ DCHECK(_hash_set.size() <= HLL_EXPLICIT_INT64_NUM)
Review comment:
DCECK will ignored in release build. How this change can fix this bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
