This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 10ee48bb6fa [fix](publish version) publish version task no need return
VERSION_NOT_EXIST #27005
10ee48bb6fa is described below
commit 10ee48bb6fa96e6a9190882dd1dc0079cc20fc4c
Author: yujun <[email protected]>
AuthorDate: Wed Nov 15 21:09:54 2023 +0800
[fix](publish version) publish version task no need return
VERSION_NOT_EXIST #27005
if BE's tablet not contains a txn, publish txn on them will no error, when
check version exists it will indicate the tablet as error_tablet_id in task's
response, so FE can know this tablet has fail.
Also for task, it's no need to set its status as "VERSION_NOT_EXIST".
Because if set it as not ok, the BE will try this task two times. Since not
contains this tablet's txn, the retry is in vain.
---
be/src/olap/task/engine_publish_version_task.cpp | 6 ------
1 file changed, 6 deletions(-)
diff --git a/be/src/olap/task/engine_publish_version_task.cpp
b/be/src/olap/task/engine_publish_version_task.cpp
index 040b5a7edea..ff327d5bc40 100644
--- a/be/src/olap/task/engine_publish_version_task.cpp
+++ b/be/src/olap/task/engine_publish_version_task.cpp
@@ -242,12 +242,6 @@ Status EnginePublishVersionTask::finish() {
(*_succ_tablets)[tablet_id] = 0;
} else {
add_error_tablet_id(tablet_id);
- if (res.ok()) {
- res = Status::Error<VERSION_NOT_EXIST>(
- "tablet {} with state {} not exists
version {}", tablet_id,
- tablet_state_name(tablet->tablet_state()),
- par_ver_info.version);
- }
LOG(WARNING)
<< "publish version failed on transaction,
tablet version not "
"exists. "
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
