cambyzju opened a new pull request, #27134:
URL: https://github.com/apache/doris/pull/27134

   ## Proposed changes
   Nowadays, we use network disks on the cloud, but sometimes closing them may 
fail.
   
   Here `ctx->body_sink.reset()` will close the file, but it will not check the 
return value of `::close`.
   We should better call `finish` to close the file, and check the return value 
of `::close`.
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[[email protected]](mailto:[email protected]) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to