ByteYue commented on code in PR #27091:
URL: https://github.com/apache/doris/pull/27091#discussion_r1395913717
##########
be/src/olap/tablet.cpp:
##########
@@ -2070,12 +2070,27 @@ Status Tablet::cooldown() {
}
// hold SHARED `cooldown_conf_lock`
-Status Tablet::_cooldown_data() {
+Status Tablet::_cooldown_data(RowsetSharedPtr rowset) {
DCHECK(_cooldown_replica_id == replica_id());
std::shared_ptr<io::RemoteFileSystem> dest_fs;
RETURN_IF_ERROR(get_remote_file_system(storage_policy_id(), &dest_fs));
- auto old_rowset = pick_cooldown_rowset();
+ RowsetSharedPtr old_rowset = NULL;
+
+ if (rowset) {
+ RowsetId rowset_id = rowset->rowset_id();
Review Comment:
Could we use const auto& ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
