xzj7019 commented on code in PR #27259:
URL: https://github.com/apache/doris/pull/27259#discussion_r1398635841
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -299,12 +303,41 @@ public Cost visitPhysicalHashJoin(
0
);
}
- return CostV1.of(context.getSessionVariable(), leftRowCount +
rightRowCount + outputRowCount,
+ return CostV1.of(context.getSessionVariable(),
Review Comment:
The tpcds 1T perf data would be better collected and considered, especially
q4/q11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
