englefly commented on code in PR #27261:
URL: https://github.com/apache/doris/pull/27261#discussion_r1399010867
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/SlotReference.java:
##########
@@ -80,30 +85,32 @@ public SlotReference(ExprId exprId, String name, DataType
dataType, boolean null
* @param internalName the internalName of this slot
*/
public SlotReference(ExprId exprId, String name, DataType dataType,
boolean nullable,
- List<String> qualifier, @Nullable Column column,
Optional<String> internalName) {
+ List<String> qualifier, @Nullable Column column,
Optional<String> internalName,
+ TableIf table) {
this.exprId = exprId;
this.name = name;
this.dataType = dataType;
this.qualifier =
ImmutableList.copyOf(Objects.requireNonNull(qualifier, "qualifier can not be
null"));
this.nullable = nullable;
this.column = column;
this.internalName = internalName.isPresent() ? internalName :
Optional.of(name);
+ this.table = table;
}
public static SlotReference of(String name, DataType type) {
return new SlotReference(name, type);
}
- public static SlotReference fromColumn(Column column, List<String>
qualifier) {
+ public static SlotReference fromTableAndColumn(TableIf table, Column
column, List<String> qualifier) {
Review Comment:
it is better to remove fromColumn() if it is not used any more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
