HappenLee commented on a change in pull request #5516:
URL: https://github.com/apache/incubator-doris/pull/5516#discussion_r594072448
##########
File path: be/src/olap/rowset/segment_v2/segment_writer.cpp
##########
@@ -36,12 +37,15 @@ const char* k_segment_magic = "D0R1";
const uint32_t k_segment_magic_length = 4;
SegmentWriter::SegmentWriter(fs::WritableBlock* wblock, uint32_t segment_id,
- const TabletSchema* tablet_schema, const
SegmentWriterOptions& opts)
- : _segment_id(segment_id), _tablet_schema(tablet_schema), _opts(opts),
_wblock(wblock) {
+ const TabletSchema* tablet_schema, const
SegmentWriterOptions& opts, std::shared_ptr<MemTracker> parent)
+ : _segment_id(segment_id), _tablet_schema(tablet_schema), _opts(opts),
_wblock(wblock), _mem_tracker(MemTracker::CreateTracker(
+ -1, "Segment", parent, false)) {
Review comment:
Yes, At first I add the segment id in the memtracker indeedly. But I
find the memtracker still hard to distinguish, so i remove it. I will add
segment id in the name agein~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
