caiconghui commented on a change in pull request #5564:
URL: https://github.com/apache/incubator-doris/pull/5564#discussion_r601094480
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
##########
@@ -822,7 +822,7 @@ private boolean loadTxnCommitImpl(TLoadTxnCommitRequest
request) throws UserExce
throw new UserException("unknown database, database=" + dbName);
}
- long timeoutMs = request.isSetThriftRpcTimeoutMs() ?
request.getThriftRpcTimeoutMs() : 5000;
+ long timeoutMs = request.isSetThriftRpcTimeoutMs() ?
request.getThriftRpcTimeoutMs() / 2 : 5000;
Review comment:
This is an experience value, here we just ensure that the rpc_timeout
value is larger enough than timeoutMs to keep timeout setting consistent with
before, to reduce the "call frontend service failed error" occur times. But I
think there is still some improvement we can do that we should compute the left
time that timeoutMillis minus commit time cost to improve the Probability of
publish timeout instead of "call frontend service failed" when commit or
publish version performance is poor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
