github-actions[bot] commented on code in PR #26827:
URL: https://github.com/apache/doris/pull/26827#discussion_r1403421697
##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -777,6 +939,13 @@ class FunctionUnixTimestamp : public IFunction {
return Impl::get_variadic_argument_types();
}
+ bool use_default_implementation_for_nulls() const override {
+ if constexpr (std::is_same_v<Impl, UnixTimeStampStrImpl>) {
+ return false;
Review Comment:
warning: redundant boolean literal in conditional return statement
[readability-simplify-boolean-expr]
be/src/vec/functions/function_timestamp.cpp:942:
```diff
- if constexpr (std::is_same_v<Impl, UnixTimeStampStrImpl>) {
- return false;
- }
- return true;
+ return !std::is_same_v<Impl, UnixTimeStampStrImpl>;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
