HappenLee commented on code in PR #27491:
URL: https://github.com/apache/doris/pull/27491#discussion_r1404383183
##########
be/src/vec/functions/if.cpp:
##########
@@ -321,23 +321,25 @@ class FunctionIf : public IFunction {
else_col.type->get_type_id(), call);
}
- bool execute_for_null_then_else(FunctionContext* context, Block& block,
- const ColumnWithTypeAndName& arg_cond,
- const ColumnWithTypeAndName& arg_then,
- const ColumnWithTypeAndName& arg_else,
size_t result,
- size_t input_rows_count, Status& status)
const {
+ Status execute_for_null_then_else(FunctionContext* context, Block& block,
+ const ColumnWithTypeAndName& arg_cond,
+ const ColumnWithTypeAndName& arg_then,
+ const ColumnWithTypeAndName& arg_else,
size_t result,
+ size_t input_rows_count, bool& handled)
const {
bool then_is_null = arg_then.column->only_null();
bool else_is_null = arg_else.column->only_null();
+ handled = false;
Review Comment:
seems no need set hanled false here ？ out the function have already set the
`false`
##########
be/src/vec/functions/if.cpp:
##########
@@ -321,23 +321,25 @@ class FunctionIf : public IFunction {
else_col.type->get_type_id(), call);
}
- bool execute_for_null_then_else(FunctionContext* context, Block& block,
- const ColumnWithTypeAndName& arg_cond,
- const ColumnWithTypeAndName& arg_then,
- const ColumnWithTypeAndName& arg_else,
size_t result,
- size_t input_rows_count, Status& status)
const {
+ Status execute_for_null_then_else(FunctionContext* context, Block& block,
+ const ColumnWithTypeAndName& arg_cond,
+ const ColumnWithTypeAndName& arg_then,
+ const ColumnWithTypeAndName& arg_else,
size_t result,
+ size_t input_rows_count, bool& handled)
const {
bool then_is_null = arg_then.column->only_null();
bool else_is_null = arg_else.column->only_null();
+ handled = false;
Review Comment:
seems no need set hanled false here ？ out the function have already set the
`false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
