Jibing-Li commented on code in PR #27634:
URL: https://github.com/apache/doris/pull/27634#discussion_r1405874445
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCollector.java:
##########
@@ -83,7 +74,14 @@ protected void createSystemAnalysisJob(AnalysisInfo jobInfo)
analysisManager.createTableLevelTaskForExternalTable(jobInfo,
analysisTasks, false);
}
Env.getCurrentEnv().getAnalysisManager().registerSysJob(jobInfo,
analysisTasks);
- analysisTasks.values().forEach(analysisTaskExecutor::submitTask);
+ for (BaseAnalysisTask task : analysisTasks.values()) {
+ try {
+ task.execute();
Review Comment:
Not a block. But it's better to write the successfully executed tasks'
result to column statistics table, instead of fail the whole job when one task
failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
