github-actions[bot] commented on code in PR #26809:
URL: https://github.com/apache/doris/pull/26809#discussion_r1406190034
##########
be/src/runtime/runtime_state.h:
##########
@@ -175,14 +175,22 @@ class RuntimeState {
void get_unreported_errors(std::vector<std::string>* new_errors);
[[nodiscard]] bool is_cancelled() const;
+ std::string cancel_reason() const;
int codegen_level() const { return _query_options.codegen_level; }
- void set_is_cancelled(bool v, std::string msg) {
- _is_cancelled.store(v);
- // Create a error status, so that we could print error stack, and
- // we could know which path call cancel.
- LOG(WARNING) << "Task is cancelled, instance: "
- << PrintInstanceStandardInfo(_query_id,
_fragment_instance_id)
- << " st = " << Status::Error<ErrorCode::CANCELLED>(msg);
+ void set_is_cancelled(std::string msg) {
Review Comment:
warning: method 'set_is_cancelled' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void set_is_cancelled(std::string msg) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
